Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaiad: ExportGenesisFile() incorrectly overwrites genesis #4063

Merged
merged 5 commits into from
Apr 8, 2019
Merged

gaiad: ExportGenesisFile() incorrectly overwrites genesis #4063

merged 5 commits into from
Apr 8, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 6, 2019 •
edited
Loading

ExportGenesisFile() overwrites all non-gaia related
sections of the genesis.json file as it always
creates a new one from scratch.

Remove cmd/gaia/init.LoadGenesisDoc() in favor of
tendermint's types.GenesisDocFromFile().

Closes: #4066

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 6, 2019 •
edited
Loading

Codecov Report

Merging #4063 into develop will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #4063      +/-   ##
===========================================
- Coverage    60.01%   59.95%   -0.06%     
===========================================
  Files          212      212              
  Lines        15107    15108       +1     
===========================================
- Hits          9066     9058       -8     
- Misses        5420     5428       +8     
- Partials       621      622       +1

@alessio alessio force-pushed the alessio/3130-dont-reset-tendermint-genesis-params-on-collect branch from 6b4bd28 to 0343fc3 Compare April 6, 2019 13:17
alessio added 4 commits April 6, 2019 19:06
@alessio
Add test case
a2e8f50
@alessio
gaiad: ExportGenesisFile() incorrectly overwrites genesis
d087d3d 
ExportGenesisFile() was overwriting all non-gaia related
sections of the genesis.json file as it was always
creating a new one from scratch.

Ref #3130
@alessio
Remove LoadGenesisDoc() in favor of GenesisDocFromFile()
ffd005a 
Duplication of effort discovered while on #3130
@alessio
Add changelog entry
2f0b833
@alessio alessio force-pushed the alessio/3130-dont-reset-tendermint-genesis-params-on-collect branch from 0343fc3 to 2f0b833 Compare April 6, 2019 18:09
@alessio alessio marked this pull request as ready for review April 6, 2019 18:11
@alessio alessio mentioned this pull request Apr 6, 2019
Closed
5 tasks
@alessio alessio requested a review from jleni April 7, 2019 16:50
fedekunze
fedekunze approved these changes Apr 8, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

jaekwon
jaekwon reviewed Apr 8, 2019
View reviewed changes
cmd/gaia/init/utils.go Outdated Show resolved Hide resolved
@alessio alessio merged commit fbc6bda into develop Apr 8, 2019
@alessio alessio deleted the alessio/3130-dont-reset-tendermint-genesis-params-on-collect branch April 8, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaekwon jaekwon jaekwon left review comments

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@mossid mossid Awaiting requested review from mossid

@sabau sabau Awaiting requested review from sabau

@zmanian zmanian Awaiting requested review from zmanian

@jleni jleni Awaiting requested review from jleni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @jaekwon @alexanderbez @fedekunze